[PATCH] Next rev of Windows service support (Feb 27)

I've incorporated Branko's feedback, and am resubmitting the Windows service
support patch.

* windows-service.txt updated
* svn_ prefix removed from filenames
* Debug print statements controlled by SVN_DEBUG
* Fewer #ifdefs in main.c
* Clarified install docs on quoting the binpath string (it works)
* All conditional code controlled by _WIN32
* All lines < 80 columns
* Eliminated use of _vsnprintf
* docstrings for exported functions
* Uses apr_os_sock_get instead of directly accessing sockdes field

I welcome additional feedback. However, I would appreciate it if reviewers
would clearly indicate whether a specific comment means that something must
be changed in order for the patch to be accepted, or should be addressed
later, or is just a "comment" and not a "this has got to change".

I searched for info on docstrings and found very little. hacking.html does
not mention docstrings. I wrote comments next to function prototypes in
headers, using the pattern of other header files. If this is not correct,
please advise.

I have intentionally not altered INSTALL, because it is not clear whether I
should add a link to windows-service.txt, or simply move the
windows-service.txt into INSTALL. I think the best thing is to check in
windows-service.txt as is, and then massage the docs later, as people see
fit. This patch is intended to get the basic service support checked in and
available to people, while future patches will work on getting all of the
docs, installation apps, etc. plugged in.

Thanks.

-- arlie

[[[

Adds support to svnserve to run as a native Windows service.
This allows svnserve to start automatically, at system boot
time, without having a user logged in and without the need
for an external service 'wrapper' program.

Usage is described in detail in notes/windows-service.txt.
Design notes are in comments in the source code.

======================================================================

* subversion/svnserve/main.c
  (main): updated to support running as a Windows service
          Adds new --service run mode

* subversion/svnserve/winservice.h: Added
  Contains public declarations for service support

* subversion/svnserve/winservice.c: Added
  Contains implementation of service support

* notes/windows-service.txt: Added
  Contains notes on how to use service support (install, start, stop,
  uninstall)
]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org