[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch to neon library detection code.

From: Paul de Vrieze <pauldv_at_gentoo.org>
Date: 2006-02-27 17:49:37 CET

On Monday 27 February 2006 14:50, Marcus Rueckert wrote:
> On 2006-02-27 14:24:04 +0100, Paul de Vrieze wrote:
> > I've identified an issue with the gentoo package for subversion. The
> > configure script continues hapilly when external neon support was
> > specified but not found (wrong version). I've created a small patch
> > to remedy this.
>
> That is incorrect. An user can run svn without neon happily. he can
> still use file:// or svn:// or svn+ssh://. so enforcing neon is not
> needed. i would suggest applying this patch in your ebuild and pass an
> USE flag for it. so only if the user specifies to use neon your build
> should fail. otherwise it can happily ignore neon.

I've checked, and the patch is indeed incorrect. It fails always when neon
is not found. Even with --without-neon. This patch should be better,
although it duplicates some code.

Paul

-- 
Paul de Vrieze
Gentoo Developer
Mail: pauldv@gentoo.org
Homepage: http://www.devrieze.net

  • application/pgp-signature attachment: stored
Received on Mon Feb 27 19:39:24 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.