Peter N. Lundblad wrote:
> On Sun, 26 Feb 2006, Edmund Horner wrote:
>
>> The easiest solution that I can see is to use plain old temporary file
>> names instead of full paths. Max Bowsher suggested I write a patch to
>> that effect (attached).
>>
>> However I've noticed that building out the full diff tree is intentional
>> in svnlook (print_diff_tree). My patch seems to work (it gives
>> identical diffs for those revisions I've tried that don't contain
>> unusual paths), but I'm not 100% certain of the reason for doing it this
>> way...
>>
> The only reason I can think of for generating the full paths would be to
> get correct output when svnlook was using an external diff program (which
> it was long ago).
Ah yes that might be it. I guess there are no plans to allow an
external diff tool for svnlook in the near future?
> I think we can get rid of the temporary dir completely. Setting the
> permissions was done to avoid a security hole (symlink attack), which
> isn't necessary when we use the system temporary directory directly.
>
> Otherwise, the patch looks good at a quick glance.
Ok, I'll rewrite it to get rid of tmpdir and create_unique_tmpdir,
unless someone else has anything to say about it.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Feb 26 03:49:11 2006