Re: [PATCH] Windows service support

Joseph Galbraith wrote:
>> We use WIN32, not _WIN32, and this define is obviously not necessary.
>>
>
> We might want to consider changing that, since it
> appears that WIN32 isn't defined when building for
> 64-bit, but _WIN32 is.
>
IIRC we define WIN32 in our project files.

> In other words, _WIN32 appears to be the correct define
> if you mean #if "this is the win32 api" and WIN32 appears
> to be the correct define if you mean "this is the
> 32-bit version of the win32 api."
>
But yes, the moment we start porting Subversion to Win64 (I haven't
heard of anybody actually building 64-bit Windows binaries yet), we'll
need three symbols instead of one:

    * A generic one meaning "this is Windows"
    * Two specific ones, one for Win32 and one for Win64.

Although I personally hope we won't ever need the specific versions.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 25 13:37:56 2006