Do you believe this work is a prerequisite to accepting the Win32 service
patch?
-- arlie
-----Original Message-----
From: rooneg@gmail.com [mailto:rooneg@gmail.com] On Behalf Of Garrett Rooney
Sent: Friday, February 24, 2006 5:14 PM
To: Arlie Davis
Cc: Ivan Zhakov; dev@subversion.tigris.org
Subject: Re: Diffs for running svnserve as a Win32 service
On 2/24/06, Arlie Davis <adavis@stonestreetone.com> wrote:
> Ok, so tell me what you would consider sufficient for this patch.
> Again, I would LOVE to be able to shut down svnserve cleanly, and I
> have already structured the code around this, so that any future
> developer that DOES provide clean shutdown can see clearly how to
> integrate it with the service support.
>
> So tell me how to do it.
Off the top of my head, the apr_socket_accept needs to be changed to a
poll/accept system, where you poll to see if there's anything to accept,
then accept. The poll should have a timeout so that when you finish polling
you can check to see if we have been told to shut down.
The actual shutdown command would come from a signal handler or something
like that.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 24 23:18:04 2006