Re: Diffs for running svnserve as a Win32 service

On 2/23/06, Arlie Davis <adavis@stonestreetone.com> wrote:
> Ok, here's the first cut of the service implementation. I welcome feedback,
> testing, etc. Before sending any feedback, though, please read the
> instructions below, especially the "Known Issues" section.
>
First of all, please provide log message as hacking.html states.

I closely look to you patch latter. But there are several things that
I mentioned while quick look through:
There are already implemented svn_error_wrap_apr(), apr_get_os_errro()
and APR_FROM_OS_ERROR which is better than home-bred
svn_error_create_win32()/get_win32_error_text()
Also better use Apache Portable Runtime API for thread operations and
might for closing sockets (apr_socket_close as HTTPD does). Look to
APR documentation: http://apr.apache.org/docs/apr/

--
Ivan Zhakov