Arlie Davis wrote:
> Ok, here's the first cut of the service implementation. I welcome feedback,
> testing, etc. Before sending any feedback, though, please read the
> instructions below, especially the "Known Issues" section.
Thanks. This isn't my area at all, so just two meta-comments.
At some point it would be good if you could read through the relevant parts of
our "Hacker's Guide to Subversion" <http://subversion.tigris.org/hacking.html>.
The first thing that would be nice to see is a log message
<http://subversion.tigris.org/hacking.html#log-messages>; it doesn't matter
that this version of the patch isn't ready for commit, the log message would
help reviewers to understand the structure and purpose of it and its parts.
The second thing, and believe me when I say I'm VERY reluctant to mention it,
is to ask what is the legal situation regarding you contributing code that
makes use of these Microsoft APIs? Hopefully it's fine, after all you wrote
the code, but I've a nasty feeling I heard some time ago that there might be a
problem in a situation like this because of the terms of the license agreement
for the development kit you use (API documentation etc.). Sorry if this is an
unwelcome question, but I've noticed the project members are quite keen to make
sure things are above board so I'd better ask.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 23 03:26:41 2006