Philip Martin <philip@codematters.co.uk> wrote on 02/22/2006 01:35:32 PM:
> Paul Burba <paulb@softlanding.com> writes:
>
> > This patch blocks AS400 dependent code in two places like this:
> >
> > SVN_ERR(svn_path_cstring_from_utf8(&unique_name_apr, unique_name,
> > pool));
> > #ifdef AS400
> > apr_err = os400_file_create_prep(unique_name_apr, &flag,
> > APR_OS_DEFAULT, pool);
> > if (!apr_err)
> > #endif
> > apr_err = apr_file_open(&file, unique_name_apr, flag | APR_BINARY,
> > APR_OS_DEFAULT, pool);
> >
> > This obviously is improperly indented code, but is something like this
> > ever acceptable considering the alternative would result in redundant
code
> > and generally be more intrusive?
>
> It's not too bad IMO, however I would prefer an alternative solution,
> see below.
Hi Philip,
Thanks as always for taking the time to look at our OS400/EBCDIC patch.
I'm going to try and resolve Julian's concerns first since they involve
the fundamental viability of this patch. I'll be back to you shortly.
Thanks,
Paul B.
_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 22 22:32:34 2006