[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: patch newline in log messages

From: Olleg Samoylov <olleg_at_mipt.ru>
Date: 2006-02-22 15:23:57 CET

Julian Foad wrote:

Hi Julian :).

> Olleg Samoylov wrote:
> Issue #1870 "Don't add extra blank line to log messages" is the right
> one. It contains a patch to not add an extra line to an EMPTY log
> message, but it should discuss the whole issue of trailing newlines.

I already sent patch half year ago to remove trailing newlines at stage
  "svn commit". There was a great discussion about it. And you took part
in it also. But in spite of your support, Karl Fogel rejected it. Reason
was:

> I am totally, completely opposed to Subversion taking the trailing
> newline off my log messages. Take my house, take my car, take my
> piano (well, no, leave the piano please) but DO NOT TAKE my trailing
> newline.

And from Greg Hudson:

> in the ideal case, svn:log properties should be thought of as a series
> of lines, and we should ensure that they are by requiring that they have
> a final newline.
>
> Since we can't (or at least don't want to) modify the svn:log properties
> of existing repositories, we would also append a final newline in the
> display code to svn:log properties which don't have one.

Now I write patch worked at stage "svn log". What I need to do also to
fix this very old issue?

-- 
Olleg Samoylov

Received on Wed Feb 22 15:25:09 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.