Paul Burba wrote:
> Hi Brane,
>
> Thanks for the info. Mark and I talked about this offline and agree that
> your approach is probably the right way to go.
Since APR is our portability layer, it certainly makes sense to use
APR's portability mechanisms where available.
> So here is a patch to all
> files that call strcasecmp() and/or strncasecmp() and don't already have
> #define APR_WANT_STRFUNC and #include <apr_want.h>.
>
> You are contractually obligated to approve it now since it was your idea,
> right? ;-)
>
Only if you first fix the nits I found, right! :)
(And if it passes the tests, of course.)
> Thanks,
>
> Paul B.
>
> [[[
> Support platforms with old BSD-style string.h and strings.h headers.
>
> OS400 is the only platform this is currently known to affect.
>
s/to affect/to be affected/
> * subversion/libsvn_ra/ra_loader.c
> * subversion/libsvn_ra_serf/serf.c
> * subversion/libsvn_ra_serf/update.c
> * subversion/libsvn_ra_serf/util.c
> * subversion/libsvn_subr/opt.c
> * subversion/libsvn_subr/subst.c
> Define APR_WANT_STRFUNC and include apr_want.h.
>
Yes, *and* remove explicit includes of string.h
> ]]]
>
> Index: subversion/libsvn_ra/ra_loader.c
> ===================================================================
> --- subversion/libsvn_ra/ra_loader.c (revision 18537)
> +++ subversion/libsvn_ra/ra_loader.c (working copy)
> @@ -19,6 +19,8 @@
> /* ==================================================================== */
>
> /*** Includes. ***/
> +#define APR_WANT_STRFUNC
> +#include <apr_want.h>
>
> #include <string.h>
>
This last include should go. And any others you happened to have forgotten.
Otherwise, yes, this is what I had in mind.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 22 14:02:55 2006