Re: [PATCH] v2 Add archive support to hot-backup

Thanks Dan for the review.

Here's an updated version of the patch and log.

Regards
Chris

[[[Log]]]

Add option to archive the backup using gz, bz2 or zip.

* tools/backup/hot-backup.py.in
  Update copyright year.
  (archive_map): New. Supported archive extentions.
  (usage): New. Print out a usage message.
  Add optional 3rd arg to the command line to specify the archive type.
  (comparator): If archiving, add the archive extenstion to the regexp to
    find archives as well.
  Step 2, also find archives.
  Step 4, archive backup.
  Step 5, look for archives to remove as well.

----- Original Message -----
From: "Daniel Rall" <dlr@collab.net>
To: "Chris Foote" <cfoote@v21.me.uk>
Cc: <dev@subversion.tigris.org>
Sent: Monday, February 20, 2006 2:49 AM
Subject: Re: [PATCH] Add archive support to hot-backup

> This patch seems pretty reasonable. A couple comments:
>
> 1) Changes to arguments processing aren't mentioned in the log
> message.
>
> 2) Description of the changes to comparator in the log message could
> be a little more clear.
>
> 3) Error handling for a failed import vs. failed execution should be
> more verbose, with the error string differentiating between the two
> cases (instead of using a single, generic "failed" message for both).
>
> - Dan
>
> On Sun, 19 Feb 2006, Chris Foote wrote:
>
> > This patch adds archive support to the hot-backup.py script using the python
> > modules. This is especially useful on Windows.
> >
> > Regards
> > Chris
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org