Mark Phippard <markp@softlanding.com> wrote on 02/21/2006 12:21:38 PM:
> Paul Burba/SoftLanding Systems wrote on 02/21/2006 12:14:21 PM:
>
> > Thanks for the info. Mark and I talked about this offline and agree
> that
> > your approach is probably the right way to go. So here is a patch to
> all
> > files that call strcasecmp() and/or strncasecmp() and don't already
have
>
> > #define APR_WANT_STRFUNC and #include <apr_want.h>.
> >
> > You are contractually obligated to approve it now since it was your
> idea,
> > right? ;-)
> >
> > Thanks,
> >
> > Paul B.
> >
> > [[[
> > Support platforms with old BSD-style string.h and strings.h headers.
> >
> > OS400 is the only platform this is currently known to affect.
> >
> > * subversion/libsvn_ra/ra_loader.c
> > * subversion/libsvn_ra_serf/serf.c
> > * subversion/libsvn_ra_serf/update.c
> > * subversion/libsvn_ra_serf/util.c
> > * subversion/libsvn_subr/opt.c
> > * subversion/libsvn_subr/subst.c
> > Define APR_WANT_STRFUNC and include apr_want.h.
> > ]]]
>
> I noticed you did not delete the #include for string.h as part of this
> patch. Wouldn't that be the correct way to do it?
Mark - Indeed it is, corrected below.
> I am also adding Justin to the cc: list since this included changes to
> ra_serf.
>
> Mark
[[[
Support platforms with old BSD-style string.h and strings.h headers.
OS400 is the only platform this is currently known to affect.
* subversion/libsvn_ra/ra_loader.c
* subversion/libsvn_ra_serf/serf.c
* subversion/libsvn_ra_serf/update.c
* subversion/libsvn_ra_serf/util.c
* subversion/libsvn_subr/opt.c
* subversion/libsvn_subr/subst.c
Define APR_WANT_STRFUNC and include apr_want.h. Remove
#include <string.h> if present.
]]]
_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 21 18:45:08 2006