Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote on 02/20/2006 05:13:15
PM:
> On Mon, Feb 20, 2006 at 04:16:15PM -0500, Paul Burba wrote:
> > +#ifdef AS400
> > +#define SVN_UTF_UTOE_XLATE_HANDLE "svn-utf-utoe-xlate-handle"
> > +#endif
>
> That #define should be included from the relevant header file, not
> duplicated here. [I am right in thinking that it was added somewhere
> as part of one of your other patches, aren't I? Ignore me if not.]
>
> Regards,
> Malcolm
Hi Malcolm,
That symbol is not defined in a header file. My thought was to follow the
example of the other SVN_UTF_*TO*_XLATE_HANDLE defines, putting them not
in a header file but in the *.c file that uses them:
cmdline.c:
#define SVN_UTF_CONTOU_XLATE_HANDLE "svn-utf-contou-xlate-handle"
#define SVN_UTF_UTOCON_XLATE_HANDLE "svn-utf-utocon-xlate-handle"
utf.c:
#define SVN_UTF_NTOU_XLATE_HANDLE "svn-utf-ntou-xlate-handle"
#define SVN_UTF_UTON_XLATE_HANDLE "svn-utf-uton-xlate-handle"
My OS400/EBCDIC patches have added the following (so far):
io.c:
#define SVN_UTF_UTOE_XLATE_HANDLE "svn-utf-utoe-xlate-handle"
cmdline.c:
#define SVN_UTF_ETOU_XLATE_HANDLE "svn-utf-etou-xlate-handle"
Of course the #defines in utf.c were added way back in 2002 and
probably(?) haven't gotten much attention since. Looking at this now, it
seems *all* the SVN_UTF_*TO*_XLATE_HANDLE symbols should be in svn_utf.h.
I'm glad to put a patch together that does this if you think it's a better
approach.
Let me know, thanks,
Paul B.
_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 21 14:20:09 2006