Re: Recent binding test failures

Hi,

In <Pine.LNX.4.55.0602200928370.5197@localhost.localdomain>
  "Re: Recent binding test failures" on Mon, 20 Feb 2006 09:30:39 +0100 (CET),
  "Peter N. Lundblad" <peter@famlundblad.se> wrote:

> On Fri, 10 Feb 2006, Kouhei Sutou wrote:
>
> > In <Pine.LNX.4.55.0602082248230.6433@localhost.localdomain>
> > "Re: Recent binding test failures" on Wed, 8 Feb 2006 22:51:16 +0100 (CET),
> > "Peter N. Lundblad" <peter@famlundblad.se> wrote:
> >
> > > > ctx->notify_func = collect_notify_path_function;
> > > > svn_client_commit(ctx);
> > > >
> > > > assert(collected_notify_paths == [path1, path2]);
> > > > # but
> > > > # collected_notify_paths == [path1, path2, full_path_of_path2]
> > > >
> > > >
> > > > Is this helps you?
> > > >
> > > No:-( Is that collected_notify_paths what the notification callback gets?
> > > I don't understand. When I move a file in a test repo, the notifier only
> >
> > collect_notify_paths just only collect notified paths by
> > using passed svn_wc_notify_t * object. And it assigns
> > collected notified paths to collected_notify_paths.
> >
> > Is this explain help you?
> >
> >
> > > When I move a file in a test repo, the notifier only
> > > gives two paths.
> >
> > Could you show us your test code?
>
> I try to reproduce this using the cmdline client. Maybe this can only be
> triggered using the API? :-( Below is my script. The output looks
> correct to me.
>
> echo s1 > f1
> svn add f1
> svn ci -m m
> echo s2 > f1
> echo "Below should fail!"
> svn mv f1 f2
> svn cleanup
> echo "MOve --force:"
> svn mv --force f1 f2
> svn ci -m m

It's OK that the last 'svn ci' success. This is same
behavior in Ruby bindings test suites.

This problem is that notified informations from
svn_client_commit() have a garbage. In svn-breakage,
"/svntest/obj-sh/subversion/bindings/swig/ruby/test/wc-tmp/wc/sample2.txt"
is the garbage.

> 1) Failure:
> test_move_force(SvnClientTest) [/srv/svntest/svntest/svn/svn_trunk/subversion/bindings/swig/ruby/test/test_client.rb:969]:
> <["test/wc-tmp/wc/sample1.txt", "test/wc-tmp/wc/sample2.txt"]> expected but was
> <["/svntest/obj-sh/subversion/bindings/swig/ruby/test/wc-tmp/wc/sample2.txt",
> "test/wc-tmp/wc/sample1.txt",
> "test/wc-tmp/wc/sample2.txt"]>.

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org