[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18462 - in trunk/subversion: libsvn_fs libsvn_fs_base libsvn_fs_fs

From: Branko Čibej <brane_at_xbc.nu>
Date: 2006-02-16 03:22:33 CET

Peter N. Lundblad wrote:
> On Tue, 14 Feb 2006 kfogel@tigris.org wrote:
>
>
>> Author: kfogel
>> Date: Tue Feb 14 15:22:35 2006
>> New Revision: 18462
>>
>> Log:
>> Fix issue #2398: bogus pointer comparison led to server-side assert failure.
>>
>> * subversion/libsvn_fs/fs-loader.h, subversion/libsvn_fs/fs-loader.c
>> (svn_fs__same_p): New function.
>>
>> * subversion/libsvn_fs_fs/tree.c
>> (copy_helper): Use above to check equality of the two filesystems,
>> instead of depending on pointer equality. Handle inequality by
>> returning an error, instead of failing an assertion.
>>
>> * subversion/libsvn_fs_base/tree.c
>> (copy_helper): Same.
>>
>>
> Hmmm, I thought such circular dependencies were not supported on
> Windows...
>
Circular dependencies, as you call them, are supported. Unresolved
symbols while creating a DLL are not. So things like this will work for
now, but will likely cause problems once we start creating DLLs on
Windows. We can burn^H^H^H^Hcross that bridge when we get to it.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 20 09:32:09 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.