RE: [Issue 2486] New - Svnserve 1.3 authz: writing on subfolder requires read access on repository root

David,

I'd like to fix this issue so it can be included in svn 1.3.1. I know you're
busy these days, so I just need some information from you so I can provide a
patch myself.

> -----Original Message-----
> From: David Anderson [mailto:david.anderson@calixo.net]
> Sent: dinsdag 24 januari 2006 9:55
...
>
> So, my take on all this is that svnserve's implementation is
> indeed faulty, as it was supposed to copy mod_authz_svn's
> implementation. The solution is to either correct svnserve
> (I believe the fix is a two-liner - remove read access check
> on opening directories in the commit editor), or introduce an
> 'x' bit that explicitely identifies the right to traverse directories.
>
> - Dave.

If I understand you correctly, you propose to remove these lines in
open_root():

  /* Check read access to root */
  SVN_ERR(check_authz (eb, "/", eb->txn_root, svn_authz_read, pool));

from svn_repos/commit.c right? Let's keep adding the 'x' bit for later (
issue 2298 is already available for that purpose ).

I know you added these lines when implementing authz for svnserve 1.3, so
removing then will probably not have impact of other usage scenario's. I'll
provide some test scripts to validate that anyhow.

regards,

Lieven.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Feb 19 18:31:18 2006