Max,
thanks for your input. I'll cleanup/fix the code where needed and send a new
version later today. I'll include the collabnet license as well.
Quoting Max Bowsher <maxb1@ukf.net>:
> I'm inclined to put it under tools - it's small enough and useful enough
> that providing the greater level of maintenance implied by tools vs.
> contrib isn't going to be a problem.
>
> Though, I would like to see a few things fixed first:
>
> Compile command:
> Does not need apache include files or libraries.
> Does not need to link libsvn_client
> DOES need to link libsvn_repos and libsvn_subr
>
> Usage message:
> s/when/if/
> What does it return if content is not ok?
>
> Actually, it would be nice if it could return:
> 0 => Syntax OK
> 1 => Syntax Bad, no other error
> 2 => Operational error
> (Drop usage of the EXIT_SUCCESS|FAILURE defines entirely, since they
> don't really make sense unless you are using them exclusively.)
I suppose EXIT_SUCCESS = 0 & EXIT_FAILURE = 1?
> Should not pass "minimal_client" to svn_cmdline_init().
>
> Remove the very elementary comments inherited from minimal_client.
>
> Remove the "shouldn't I clean the pool object here" comment. Call
> svn_pool_destroy(pool); apr_terminate(); to illustrate good practices.
Ok, that's what I needed.
>
> Max.
Lieven.
----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 17 11:45:40 2006