[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18486 - trunk/subversion/libsvn_ra_serf

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-02-17 09:40:37 CET

On Fri, 17 Feb 2006 kfogel@collab.net wrote:

> "Peter N. Lundblad" <peter@famlundblad.se> writes:
> > On Thu, 16 Feb 2006, Justin Erenkrantz wrote:
> > > On 2/16/06, Daniel Rall <dlr@collab.net> wrote:
> > > > Comment doesn't add a lot of additional value. I recommend either
> > > > removing it, or being a bit more verbose:
> > >
> > > I'll remove the comment.
> > >
> > +1. I think our requirement in HACKING to "document everything" is too
> > strict, btw.
>
> The hacking.html guidelines do not require one to put a comment next
> to every variable in a function. The guidelines do require that every
> function be documented, and no, I don't think that's too strict :-).
>

Well...

"For structure types, document each individual member of the structure as
well as the structure itself."

I think that's a little overkill.

Best,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 17 09:41:23 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.