kfogel@collab.net wrote:
> Kamesh Jayachandran <kamesh@collab.net> writes:
>
>> The proposed solution properly undoes test '.ssh' setup upon test
>> completion.
>>
>> So I could not see any mess here.
>> May be abrupt termination of 'make svnsshcheck'(^C or make exiting
>> with errors) before 'restoresshsetup' could cause redundant entries in
>> the .ssh/authorized_keys file, in the case I can document this
>> behaviour and ask people to run 'make restoresshsetup' to cleanup this
>> trivial redundancy.
>>
>> Let me know if you meant something else.
>>
>
> Even assuming the tests run to completion (which, as you note, is not
> a safe assumption), the tests still take a long time and a person
> might use their .ssh directory during that time. I often do, in fact.
>
>
The patch tries to append the newly created pub keys(jconstant/jrandom)
to ~/.ssh/authorized_keys file so the existing ssh key configuration
still holds.
If you mean that some hand edit/some other tool changes
~/.ssh/authorized_keys file while the tests are running and 'undo' just
ignore this changes.
Then could modify my 'undo' to be more intelligent by removing what
exactly has been written by the auto setup.
Let me know if I miss something.
With regards
Kamesh Jayachandran
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 16 05:46:06 2006