any spaces ever? (was: Results of: [VOTE] New space-before-parens ...)

On Wed, Feb 15, 2006 at 05:26:03PM +0000, Julian Foad wrote:
>...
> >- SVN_ERR (svn_fs_make_file (txn_root, "q", pool));
> >- SVN_ERR (svn_fs_make_dir (txn_root, "A", pool));
> >+ SVN_ERR(svn_fs_make_file(txn_root, "q", pool));
> >+ SVN_ERR(svn_fs_make_dir (txn_root, "A", pool));
>
> There are not many cases of that, I think. I don't think we should worry
> too much about keeping the horizontal alignment of cases like the one I
> quoted here, but if you edit this by hand I'd say it's OK to keep a space
> after "_dir" there to keep the alignment. (This quote is from a longer
> section so the alignment is worth something.)

No. Still not allowed there.

Part of the dev-process with the no-space model is being able to
search for "dir(" so that you can find calls to the svn_fs_make_dir
function without picking up "dir" in random places. And without having
to type the full svn_fs_make_dir. Yup, a user strategy, but an
incredibly effective/efficient one.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org