Re: Results of: [VOTE] New space-before-parens style

kfogel@collab.net wrote:
>
> Thank you for the excellent review, Julian!
>
> I think that's enough to proceed. I'll fix up what I can by hand, but
> it's not a disaster if a few odd spots remain scattered throughout the

Now I'm getting scared. We don't have the tools to handle this. Your diff is
against r18463, and HEAD is r18468, and 17 files have been changed in that time.

* GNU "patch" to a HEAD WC failed on most of those changed files. (Its
"--ignore-whitespace" option only ignores changes to sequences of one or more
whitespace characters, not total removal or addition thereof.)

* "svn update" couldn't update most of those changed files, after I'd applied
your patch to a WC at r18463.

> Updating now. Will re-run the procedure, do the hand cleanups, and
> commit. If you're lucky, I'll try running the tests first :-).

May I suggest you improve the automated part as much as you feel is worthwhile,
but don't spend much time doing or re-doing the manual parts yet, and hold off
(indefinitely? :-| ) from applying this patch until we know something of how to
handle the fall-out.

Argh, yes, we should have known ... sort of expected ... didn't really
appreciate the magnitude of the difficulties it would cause.

What do we need?

* "svn diff" to ignore whitespace. This work is under way.

* "patch" to ignore whitespace. For some of us, a hacked version of GNU patch
might do fine and might not be difficult.

* "svn up" to ignore whitespace. Anyone? Also, how important is this? It's
pretty much essential unless all developers have clean WCs at the time they
update to this particular revision. There is a particular danger in that there
is no automated way to revert an "svn update" that suffers conflicts.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 15 19:06:25 2006