[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] #2 Update on port to OS400/EBCDIC - Complete Log Message

From: Paul Burba <paulb_at_softlanding.com>
Date: 2006-02-15 17:08:28 CET

Sorry, I forgot to include the complete log message on that previous patch
a few minutes ago.

Paul B.

[[[
OS400/EBCDIC Port: Handle xlate page differences.

This is the second of several patches to allow Subversion to run on IBM's
OS400 V5R4.

OS400 uses integers (Coded Character Set Identifiers or CCSIDs in
IBM-speak) to represent charsets rather than strings, e.g. 1208 vs.
"UTF-8". This has two implications for the subversion code:

  1) apr_xlate_open() has a different signature, taking ints for topage
     and frompage.

  2) APR_DEFAULT_CHARSET and APR_LOCALE_CHARSET are of type int not
     const char *.

The addition of new "wrapper" symbols for APR_DEFAULT_CHARSET and
APR_LOCALE_CHARSET address the bulk of these problems, leaving only
some minor error message creation tweaks.

* subversion/include/svn_utf.h
   (SVN_APR_LOCALE_CHARSET, SVN_APR_DEFAULT_CHARSET): New symbol
    replacements for APR_LOCALE_CHARSET and APR_DEFAULT_CHARSET
    respectively.

* subversion/libsvn_client/diff.c
   (svn_client_diff2, svn_client_diff_peg2):
* subversion/libsvn_diff/diff_file.c
   (svn_diff_file_output_unified):
* subversion/libsvn_subr/cmdline.c
   (svn_cmdline_output_encoding):
    Use SVN_APR_LOCALE_CHARSET in place of APR_LOCALE_CHARSET.

* subversion/libsvn_subr/utf.c
   (SVN_APR_UTF8_CHARSET) New symbolic constant.
   (get_xlate_handle_node): Use SVN_APR_DEFAULT_CHARSET and
    SVN_APR_LOCALE_CHARSET in place of APR_DEFAULT_CHARSET and
    APR_LOCALE_CHARSET respectively. Disable assert that doesn't
    apply to V5R4 and handle error condition this may now permit.
    Cast arguments to apr_xlate_open() to agree with OS400 signature.
   (convert_to_stringbuf): Account for fact xlate_handle_node_t
    topage and frompage members are always ints on OS400 when
    creating error messages.
]]]

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 15 17:32:41 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.