On 2/14/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> On Tue, 14 Feb 2006, Michael Sinz wrote:
>
> > Ivan Zhakov wrote:
> > > On 2/14/06, rooneg@tigris.org <rooneg@tigris.org> wrote:
> > >> Log:
> > >> Fix issue #2503, assertion failure cp URL -> URL.
> > >>
> > > I consider it is not enougn to fix only client to send valid requests.
> > > Anyway server should be aware of invalid requests without aborts(). If
> > > client use old client it still can abort server, which is very bad and
> > > can cause wedged repositories.
> >
> > I would put this even more emphatically: A server should never abort() due
> > to wire data. aborts() should only happen due to software bugs (something
> > that "can not happen" just happened) and not because input data is not of
> > the correct format, especially for externally connected servers. (That is,
> > not closely coupled and secure systems)
> >
> I think everyone on this list agrees to this. Note, however, that this
> was a client bug causing a client crash. See the issue for more info.
Peter is correct, this assert was in libsvn_client, it has zero to do
with server side code.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 14 16:36:05 2006