[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: problem revealed by issue #2398 (server-side assertion)

From: Branko Čibej <brane_at_xbc.nu>
Date: 2006-02-14 01:28:43 CET

kfogel@collab.net wrote:
> * subversion/include/svn_fs.h
> (svn_fs_same_p): New prototype.
>
> * subversion/libsvn_fs/fs-loader.c
> (svn_fs_same_p): Implement it.
>
> * subversion/libsvn_fs_fs/tree.c
> (copy_helper): Use above to check equality of the two filesystems,
> instead of depending on pointer equality.
>
> * subversion/libsvn_fs_base/tree.c
> (copy_helper): Same.
>
Why did you make this a public function if it's only used within the FS
back-ends? Making functions public without a real need for it is a bad
idea. If avoiding code duplication matters, then declare it in
fs-loader.h, with the double underscore.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 14 01:29:03 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.