On Mon, 13 Feb 2006, Paul Burba wrote:
> [[[
> OS400/EBCDIC Port: Handle xlate page differences.
>
> This is the second of several patches to allow Subversion to run on IBM's
> OS400 V5R4.
>
> OS400 uses integers (Coded Character Set Identifiers or CCSIDs in
> IBM-speak)
> to represent charsets rather than strings, e.g. 1208 vs. "UTF-8". This
> has
> two implications for the subversion code:
>
> 1) apr_xlate_open() has a different signature, taking ints for topage
> and frompage.
>
> 2) APR_DEFAULT_CHARSET and APR_LOCALE_CHARSET are of type int not
> const char *.
>
So, now we see the bad of making public API signatures platform
dependent:-( But anyway:
Instead of making this change so intrusive, could we define our own macro
for APR_LOCALE_CHARSET mapping to a string in the IBM case? I can accept
the #ifdefs in utf.c, but I would like to avoid them in the client code if
possible.
An alternative would be to define a new typedef svn_encoding_t (or
whatever), and letting it replace const char* for encoding parameters, but
that would make *our* API platform-dependent in this respect...
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 13 22:37:02 2006