[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] #1 Update on port to OS400/EBCDIC

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-02-13 15:08:38 CET

Paul Burba wrote:
>
> Sorry, I just missed this discussion Friday evening. At least I can now
> use Brane's suggestion. Just one problem, the only main() function that
> will currently allow us to change the argv pointers in place is
> svnversion:
>
> svnversion: int main (int argc, const char *argv[])
>
> The other command line programs declare the pointers as const:
>
> svnlook: int main (int argc, const char * const *argv)
> svn: int main (int argc, const char * const *argv)
> svnadmin: int main (int argc, const char * const *argv)
> svndumpfilter: int main (int argc, const char * const *argv)
> svnserve: int main (int argc, const char * const *argv)
> svnsync: int main (int argc, const char * const argv[])
>
> So, should I:
>
> A) Use the previous approach and create a new array?
>
> B) Modify the signatures of the offending main()s to
>
> int main(int argc, char *argv[])
>
> Brane, I'm not sure if your suggestion implied I should do this(?)

I'm happy with either way. The more I think about modifying the signatures and
using Brane's way, the more I like it: the conversion function's implementation
and interface will both be simpler, and it will also be conveniently usable on
a single string just by passing the address of a string pointer as "argv" and 1
for "argc".

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 13 15:12:23 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.