Re: Results of: [VOTE] New space-before-parens style

On Sun, 2006-02-12 at 20:56 -0600, kfogel@collab.net wrote:
> Anyone got any better ideas, before I go further down that road?
>
> -Karl

I'm thinking more along the lines of sed.

$ svn info | grep "^URL"
URL: http://svn.collab.net/repos/svn/trunk/subversion/svn
$ sed --version
GNU sed version 4.1.4
$ find -type f -iname "*.[ch]" | xargs -n1 \
sed 's:\([a-z0-9_]\+\) ([^\(c?)\)]:\1(:g' -i
$ svn diff |head -n50
Index: merge-cmd.c
===================================================================
--- merge-cmd.c (revision 18446)
+++ merge-cmd.c (working copy)
@@ -36,7 +36,7 @@
 
 /* This implements the `svn_opt_subcommand_t' interface. */
 svn_error_t *
-svn_cl__merge (apr_getopt_t *os,
+svn_cl__merge(pr_getopt_t *os,
                void *baton,
                apr_pool_t *pool)
 {
@@ -50,55 +50,55 @@
 
   /* If the first opt_state revision is filled in at this point, then
      we know the user must have used the '-r' switch. */
- if (opt_state->start_revision.kind != svn_opt_revision_unspecified)
+ if(pt_state->start_revision.kind != svn_opt_revision_unspecified)
     {
       /* sanity check: they better have given supplied a *range*. */
- if (opt_state->end_revision.kind == svn_opt_revision_unspecified)
- return svn_error_create (SVN_ERR_CL_INSUFFICIENT_ARGS, 0,
+ if(pt_state->end_revision.kind == svn_opt_revision_unspecified)
+ return svn_error_create(VN_ERR_CL_INSUFFICIENT_ARGS, 0,
                                  _("Second revision required"));
 
       using_alternate_syntax = TRUE;
     }
 
- SVN_ERR (svn_opt_args_to_target_array2 (&targets, os,
+ SVN_ERR (svn_opt_args_to_target_array2(targets, os,
                                           opt_state->targets, pool));
 
- if (using_alternate_syntax)
+ if(sing_alternate_syntax)
     {
- if (targets->nelts < 1)
- return svn_error_create (SVN_ERR_CL_INSUFFICIENT_ARGS, NULL,
NULL);
- if (targets->nelts > 2)
- return svn_error_create (SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+ if(argets->nelts < 1)
+ return svn_error_create(VN_ERR_CL_INSUFFICIENT_ARGS, NULL,
NULL);
+ if(argets->nelts > 2)
+ return svn_error_create(VN_ERR_CL_ARG_PARSING_ERROR, NULL,
                                  _("Too many arguments given"));
 
- SVN_ERR (svn_opt_parse_path (&peg_revision, &sourcepath1,
+ SVN_ERR (svn_opt_parse_path(peg_revision, &sourcepath1,
                                    ((const char **)(targets->elts))[0],
pool));

As specified, _() and N_() will not be touched, and as a consequence of
the regexp, nothing ''()'' will be touched either.

This doesn't get everything, but I think it get much of it.

-Lares

-- 
Lares Moreau <lares.moreau_at_gmail.com>  | LRU: 400755 http://counter.li.org
lares/irc.freenode.net                 |               ::0 Alberta, Canada
Public Key: 0D46BB6E @ subkeys.pgp.net |          Encrypted Mail Preferred
Key fingerprint = 0CA3 E40D F897 7709 3628  C5D4 7D94 483E 0D46 BB6E