On Sun, 12 Feb 2006, Julian Foad wrote:
> Julian Foad wrote:
> > Peter N. Lundblad wrote:
> >> On Tue, 7 Feb 2006 striker@tigris.org wrote:
> >>
> >>> --- trunk/subversion/include/svn_diff.h (original)
> >>> +++ trunk/subversion/include/svn_diff.h Tue Feb 7 22:59:24 2006
> >>> @@ -110,7 +110,10 @@
> >>> svn_error_t *(*datasource_close)(void *diff_baton,
> >>> svn_diff_datasource_e datasource);
> >>>
> >>> - /** Get the next "token" from the datasource of type @a datasource. */
> >>> + /** Get the next "token" from the datasource of type @a datasource.
> >>> + * Return a "token" in @a *token. Return a hash of "token" in @a *hash.
> >>> + * Leave @a token and @a hash untouched when the datasource is exhausted.
> >>
> >> Really? I'd say "Set @a token to NULL and leave @a hash untouched
> >> when...". That's how the implementation behaves. Fixing, if you don't
> >> object.
> >
> > Please can you say what type of data is in the hash.
>
> That was a bit curt of me. Of course I meant "Thank you very much for
> improving the doc string thus far. As you're going to be changing it again, it
> would be great if you would add some information about the types of the hash
> keys and values." It sounds like the values are "void *token"; maybe the keys
> are ... I dunno, line numbers?
>
Well, Julian, no problem regarding your first way of saying this:-) I'm
keeping this in mind when working on the diff code.
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Feb 12 20:09:02 2006