On 2/11/06, Andreas Magnusson <andreas.ch.magnusson@home.se> wrote:
[snip]
> With a corrected APR and trunk, apr_stat took between 35% and 40% of the
> total time used, only when *setting* the readonly flag. How serious in
> the real world this is, I cannot say.
And it's utterly wasted since setting permissions on Win32 isn't even
implemented in APR (and I'm not sure you can reasonably implement
setting ACL permissions from a limited u/g/w API like APR currently
has).
>
> After I changed svn_io_set_file_read_write_carefully to be just
> set/clear the readonly flag on Windows, apr_stat disappeared from the
> "top" list (landing on 2% total time), being replaced by apr_file_rename
> and apr_file_open (which seems reasonable).
Can you clean it up and submit a patch for discussion? Personally I
think it is pointless to try to fiddle with permissions in an ACL
system -- you almost always just want to inherit the container
permissions. And Subversion currently only fiddles with the readonly
file attribute anyway. But we'll have to see what the other devs
think.
DJ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 11 17:12:29 2006