Re: [PATCH] svn diff --summarize

Martin Hauner wrote:
> Added missing copyfrom info for files in the diff summarize editor.
>
> * subversion/libsvn_client/repos_diff_summarize.c
> (add_file): Set copyfrom info in svn_client_diff_summarize_t.

Thank you very much. This certainly seems necessary, but it doesn't make the
feature work because the copy-from information is not being supplied to these
add_file() and add_directory() callbacks by their callers.

In my tests, with an ra_local repository,

   subversion/libsvn_repos/reporter.c:update_entry()

is the caller, and it simply passes NULL and SVN_INVALID_REVNUM. Could we make
it find and pass on the information?

I note that another potential caller does the same; I'm not sure in what
circumstances it is used:

   subversion/libsvn_repos/delta.c:add_file_or_dir()

Against the Subversion repository (ra_dav), the calls come from

   subversion/libsvn_ra_dav/fetch.c:start_element()

which does pass copyfrom info if it was found in the XML attributes, but it is
not found there. Is that just because we don't ask for it, somewhere?

Can anybody shed light on whether this is a deficiency that can reasonably be
fixed? If not, maybe the "diff --summarize" feature (including the API) will
not be able to support copyfrom info.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 10 05:04:10 2006