[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18382 - trunk/subversion/tests/cmdline

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-02-09 02:38:12 CET

On Wed, 08 Feb 2006, Peter N. Lundblad wrote:

> On Wed, 8 Feb 2006, Peter Samuelson wrote:
>
> >
> > [dlr@tigris.org]
> > > + #to address svn+ssh urls where '+' seems to be mistaken by the re.match
> > > + escaped_exp = '^' + re.escape('URL: ' + other_A_url) + '$'
> >
> > I dunno,
> >
> > escaped_exp = '^URL: ' + re.escape(other_A_url) + '$'
> >
> > seems more readable to me.
> >
> +1. And the comment could be fixed in the same commit (space after # and
> capital letter).

Good ideas, thanks guys. Done in r18397. 

-- 
Daniel Rall

  • application/pgp-signature attachment: stored
Received on Thu Feb 9 02:38:34 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.