[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18390 - trunk/subversion/include

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-02-08 18:06:56 CET

Peter N. Lundblad wrote:
> On Tue, 7 Feb 2006 striker@tigris.org wrote:
>
>
>>Modified: trunk/subversion/include/svn_diff.h
>>Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/include/svn_diff.h?rev=18390&p1=trunk/subversion/include/svn_diff.h&p2=trunk/subversion/include/svn_diff.h&r1=18389&r2=18390
>>==============================================================================
>>--- trunk/subversion/include/svn_diff.h (original)
>>+++ trunk/subversion/include/svn_diff.h Tue Feb 7 22:59:24 2006
>>@@ -110,7 +110,10 @@
>> svn_error_t *(*datasource_close)(void *diff_baton,
>> svn_diff_datasource_e datasource);
>>
>>- /** Get the next "token" from the datasource of type @a datasource. */
>>+ /** Get the next "token" from the datasource of type @a datasource.
>>+ * Return a "token" in @a *token. Return a hash of "token" in @a *hash.
>>+ * Leave @a token and @a hash untouched when the datasource is exhausted.
>
> Really? I'd say "Set @a token to NULL and leave @a hash untouched
> when...". That's how the implementation behaves. Fixing, if you don't
> object.

Please can you say what type of data is in the hash.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 8 18:07:29 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.