Peter N. Lundblad wrote:
> On Tue, 7 Feb 2006 striker@tigris.org wrote:
>
>
>>Modified: trunk/subversion/include/svn_diff.h
>>Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/include/svn_diff.h?rev=18390&p1=trunk/subversion/include/svn_diff.h&p2=trunk/subversion/include/svn_diff.h&r1=18389&r2=18390
>>==============================================================================
>>--- trunk/subversion/include/svn_diff.h (original)
>>+++ trunk/subversion/include/svn_diff.h Tue Feb 7 22:59:24 2006
>>@@ -110,7 +110,10 @@
>> svn_error_t *(*datasource_close)(void *diff_baton,
>> svn_diff_datasource_e datasource);
>>
>>- /** Get the next "token" from the datasource of type @a datasource. */
>>+ /** Get the next "token" from the datasource of type @a datasource.
>>+ * Return a "token" in @a *token. Return a hash of "token" in @a *hash.
>>+ * Leave @a token and @a hash untouched when the datasource is exhausted.
>
> Really? I'd say "Set @a token to NULL and leave @a hash untouched
> when...". That's how the implementation behaves. Fixing, if you don't
> object.
I thought I had made the driver code clear *token before doing the
datasource_get_next_token() callback, but my memory may be slipping.
Yes, it is slipping. Looking at svn_diff__get_tokens() you are
absolutely right. "Set @token to NULL when the @a datasource is exhausted.".
Thanks,
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 8 14:17:03 2006