On Tue, 7 Feb 2006, Justin Erenkrantz wrote:
> On 2/7/06, lundblad@tigris.org <lundblad@tigris.org> wrote:
> > @@ -4,4 +4,4 @@
> > (svn_ra_open2, svn_ra_get_ra_library): continue instead of break if we
> > don't load the first scheme handler successfully.
> >
> > -Reviewed by: lundblad
> > +Review by: lundblad
>
> Huh?
>
> The template we've used is derived from the CVS one which used the
> past tense which is grammatically correct and also indicates the
> review was done *prior* to commit. Therefore, I think it should be
> 'reviewed by', not 'review by'. -- justin
>
IN hacking we have revieew by:, which is used nearly everywhere (except a
few places that I fixed). No big deal at all, but since this is for
parsing by scripts... And I don't mind either way if others want to
change this; I think it was Karl who introduced "Review by:".
//Peter the nit-picker #1 :-(
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 8 09:02:53 2006