Re: [PATCH] [Issue 1942] svn+ssh should use the port value

Kamesh Jayachandran <kamesh@collab.net> writes:

> memcpy(*argv, cmd_argv, n * sizeof(char *));
> - (*argv)[n++] = svn_path_uri_decode (hostinfo, pool);
> + if (uri->port_str != NULL)
> + {
> + (*argv)[n++] = "-p";
> + (*argv)[n++] = uri->port_str;
> + }
> + (*argv)[n++] = svn_path_uri_decode (uri->hostname, pool);

Unless i misread this, your patch breaks every agent
configuration except certain ssh or plink ones, or any other
agent definition that would happen to work with a '-p' appended
to it.

-1

-- 
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org