Re: [PATCH] Fix corner case bug in libsvn_diff

Peter N. Lundblad wrote:
>
> Attached is a fix for this, which seems a little clumsy. If anyone
> has a better solution, feel free to suggest/commit.

> * subversion/libsvn_diff/diff_file.c
> (svn_diff__file_datasource_get_next_token): Avoid returning a token
> of length 0.

I'm having trouble determining how this is supposed to work. Please, please
could someone familiar with it expand the doc string a little?

Index: subversion/include/svn_diff.h
===================================================================
--- subversion/include/svn_diff.h (revision 18347)
+++ subversion/include/svn_diff.h (working copy)
@@ -112,5 +112,7 @@

- /** Get the next "token" from the datasource of type @a datasource. */
+ /** Get the next "token" from the datasource of type @a datasource.
+ * Set @a *token to ... or to null if ... @a hash ...
+ */
    svn_error_t *(*datasource_get_next_token)(apr_uint32_t *hash, void **token,
                                              void *diff_baton,
                                              svn_diff_datasource_e datasource);

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 8 00:32:48 2006