Re: svn commit: r18356 - trunk/subversion/libsvn_ra_serf

On 2/6/06, Peter N. Lundblad <peter@famlundblad.se> wrote:

> Doxygen-style /**.

Fixed.

> > + * This enum represents the current state of our XML parsing for a REPORT.
> > + */
> > +typedef enum {
> > + REPORT,
> > + LOCATION,
>
> Indentation.

Guess what file I copied these enums from? (Did so before I fixed the
indentation.)

> > +} loc_state_e;
> > +
> > +typedef struct {
> > + /* pool to allocate memory from */
>
> And here... :-)

=)

> > + /* Return error code; if we exceed count, this may be set */
>
> What does the part after the semi-colon mean?

Coipied from the log comment; removed that part.

> > + XML_SetElementHandler(loc_ctx->xmlp, start_getloc, NULL);
>
> You don't set the end handler. Intentional?

Yes. For this get-locations report, we don't care about cdata or end
elements as everything we are interested in is an attribute to the
start tag. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 7 19:59:01 2006