[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] tiny improvement to testsuite

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-02-07 11:57:56 CET

Hi All,
While analysing few of the test failures I came across this tiny
improvement to subversion/tests/cmdline/svntest/actions.py

With regards
Kamesh Jayachandran

[[[
Patch by: Kamesh Jayachandran <kamesh@collab.net>

* subversion/tests/cmdline/svntest/actions.py
  (match_or_fail):
  From the docstring of match_or_fail it seems that it succeeds for match on
  atleast one line. In that case on first match itself 'for' loop can be
broken,
  rather than matching lines even after the successful match.
]]]

Index: subversion/tests/cmdline/svntest/actions.py
===================================================================
--- subversion/tests/cmdline/svntest/actions.py (revision 18364)
+++ subversion/tests/cmdline/svntest/actions.py (working copy)
@@ -738,6 +738,7 @@
   for line in actual:
     if re.match(expected, line):
       matched = 1
+ break
   if not matched:
     display_lines(message, label, expected, actual, 1)
     raise main.SVNLineUnequal

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 7 11:58:46 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.