[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Experimental svn diff -w

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-02-04 22:52:08 CET

On Sat, 4 Feb 2006, [UTF-8] Branko Ä^Libej wrote:

> Peter N. Lundblad wrote:
> > On Sat, 4 Feb 2006, Bruce DeVisser wrote:
> >
> >
> >> Peter wrote:
> >>
> >>> Let me first make it clear that this is just for experimentation. This
> >>> patch is very incomplete, untested and probably buggy.
> >>>
> >> I assume that means tabs will be supported as well. svn source
> >> policy is against tabs, but others have to deal with them.
> >>
> >>
> > Yes, all whitespace characters in the 7-bit ASCII range.
> >
> What about our famous ebcdic port?
>
I thought the ebcdic port was only server-side, but if it includes svnlook
(or the client), I guess Paul will handle this appropriately.

> >> Sander wrote:
> >>
> >>>> -i --ignore-case (not sure about this; it has encoding problems)
> >>>>
> >>> What's the benefit of this option? I'm trying to think of a use
> >>> case...
> >>>
> >> There are case-insensitive programming languages. Suppose a style
> >> standardisation (or standards change) is put into effect the same
> >> as subversion's whitespace standardisation now is: it would be
> >> nice if blame would work.
> >>
> >>
> > This is a good point. And to support this is probably as simple as using
> > apr_toupper and that would work in many cases. My concern is what to do
> > if/when we support other character encodings on the file content than that
> > specified by the locale. I'd like us to do that someday; I don't think
> > it'd be easy to support -i then.
> >
> Second of all, case-folding with toupper is wrong in general. But first
> of all, if we don't know the file's encoding, saying that we support
> case-insensitive diff could do more harm than good.
>
> I'm strongly against even mentioning case-insensitive diff until and
> unless we start noticing a file's internal encoding. And even then,
> case-folding is locale-dependent.
>
Yes, that's why I don't like it. We can't use the C locale-dependent
functions because they use the LC_CTYPE encoding and we can't just include
some parts of the unicode character database, because then we will have to
make up a way to portably get at the locale name... Uh, /me drops -i...

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 4 22:52:36 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.