On Wed, 1 Feb 2006 rooneg@tigris.org wrote:
> Modified: trunk/subversion/svn/diff-cmd.c
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/svn/diff-cmd.c?rev=18316&p1=trunk/subversion/svn/diff-cmd.c&p2=trunk/subversion/svn/diff-cmd.c&r1=18315&r2=18316
> ==============================================================================
> --- trunk/subversion/svn/diff-cmd.c (original)
> +++ trunk/subversion/svn/diff-cmd.c Wed Feb 1 19:32:55 2006
> @@ -36,6 +36,54 @@
>
> /*** Code. ***/
>
> +static char
> +text_mod_char (svn_client_diff_summarize_kind_t kind)
Docstring.
> +
> +static svn_error_t *
> +summarize_func (const svn_client_diff_summarize_t *summary,
> + void *baton,
> + apr_pool_t *pool)
Say what interface it implements.
...
> /* An svn_opt_subcommand_t to handle the 'diff' command.
> This implements the `svn_opt_subcommand_t' interface. */
> svn_error_t *
> Modified: trunk/subversion/svn/main.c
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/svn/main.c?rev=18316&p1=trunk/subversion/svn/main.c&p2=trunk/subversion/svn/main.c&r1=18315&r2=18316
> ==============================================================================
> --- trunk/subversion/svn/main.c (original)
> +++ trunk/subversion/svn/main.c Wed Feb 1 19:32:55 2006
> @@ -146,6 +146,8 @@
> N_("maximum number of log entries")},
> {"no-unlock", svn_cl__no_unlock_opt, 0,
> N_("don't unlock the targets")},
> + {"summarize", svn_cl__summarize, 0,
> + N_("show a summary of the results")},
> {0, 0, 0, 0}
> };
>
> @@ -297,7 +299,7 @@
> {'r', 'c', svn_cl__old_cmd_opt, svn_cl__new_cmd_opt, 'N',
> svn_cl__diff_cmd_opt, 'x', svn_cl__no_diff_deleted,
> svn_cl__notice_ancestry_opt, svn_cl__force_opt, SVN_CL__AUTH_OPTIONS,
> - svn_cl__config_dir_opt} },
> + svn_cl__config_dir_opt, svn_cl__summarize} },
This puts the new option last in the list. I think it would be better to
place it among the "diff specific" options, i.e. after --notice-ancestry
or --force. Other commands keep the "standard"
username/password/configfile etc. options last.
And last, the performance difference looks huge! I did a diff between
trunk and the 1.3.x branch (redirecting the output to /dev/null). Without
--summarize, it was 12 minutes; with --summarize it was 30 secs. Cool!
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 2 09:17:05 2006