[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17936 - trunk/subversion/include

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-12-25 01:32:00 CET

On Sat, 2005-12-24 at 14:37 -0600, dionisos@tigris.org wrote:
> +svn_stream_t * svn_stream_from_aprfile2 (apr_file_t *file,
> + svn_boolean_t disown,
> + apr_pool_t *pool);

I don't like having this flag here, and I continue not to understand
what's wrong with just creating an svn_stream_from_aprfile and disowning
it. (You answered me when I raised the question before, and I didn't
understand your answer, and I dropped the ball at that point.)

What's so special about this particular stacked stream constructor that
it requires a disown flag?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 25 01:33:40 2005

This is an archived mail posted to the Subversion Dev mailing list.