[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Re: Add svnserve --pid-file option

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-12-18 00:18:27 CET

On Fri, 16 Dec 2005, Garrett Rooney wrote:

> On 12/16/05, Peter N. Lundblad <peter@famlundblad.se> wrote:
> > So, I want to add a --pid-file option, taking a filename argument.
> > When svnserve has demonized (if it wants to), it writes the return value
> > of getpid() (and a newline) to that file. getpid() seems pretty portable
> > (Apache seems to use it directly).
> >
> +1, seems reasonable to me, although I'm not sure what it should do on
> systems without getpid()...
>
We discussed this on IRC. I checked how Apache handles this, and it seems
to just use getpid on all platforms. I don't know how it gets its
declaration, except that it includes unistd.h where available. If someone
could just check the attached patch on Windows before I commit it, it
would be appreciated.

I didn't bother to delete the pid file, since currently, svnserve doesn't
have any cleanup handling and it doesn't seem trivial to add this in a
portable way.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sun Dec 18 00:19:16 2005

This is an archived mail posted to the Subversion Dev mailing list.