[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVNDIFF1 is ready to merge

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2005-12-12 00:47:24 CET

On Sun, 2005-12-11 at 23:40 +0000, Philip Martin wrote:
> Daniel Berlin <dberlin@dberlin.org> writes:
>
> > So take a looksee at the svndiff1 branch.
>
> I ran the command
>
> $ svn diff https://svn.collab.net/repos/svn/trunk@17620 \
> https://svn.collab.net/repos/svn/branches/svndiff1@17620
>
> but that took so long I aborted it before it produced any output. So
> I updated my trunk working copy to r17620 and tried
>
> $ svn diff --old ../svn --new https://svn.collab.net/repos/svn/branches/svndiff1
>
> and that was quick enough. I wonder why the URL diff was so slow?
>
> I have only one minor niggle about the branch code:
>
> > Index: ../svn/subversion/libsvn_delta/svndiff.c
> > ===================================================================
> > --- ../svn/subversion/libsvn_delta/svndiff.c (.../../svn) (working copy)
> > +++ ../svn/subversion/libsvn_delta/svndiff.c (.../https://svn.collab.net/repos/svn/branches/svndiff1) (revision 17733)
>
> > /* Make sure we write the header. */
> > if (eb->header_done == FALSE)
> > {
> > + char svnver[4] = "SVN\0";
>
> That's a bit odd, "SVN\0" is five characters, yet svnver is only [4].

Errr, no it's not.

\0 = NULL :)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 12 00:47:50 2005

This is an archived mail posted to the Subversion Dev mailing list.