[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Badness in mod_dav_svn?

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: 2005-12-11 19:51:17 CET

Well, thanks to our excellent log message format, you can see the
history of this function. Looks like it was created by gstein way
back in the early days, then complexified a bit by me in r405 and
cmpilato in r2090. But the svn_error_clear() bit was added by
julianfoad in r8923.

Of course, at no point have errors ever been *handled* (i.e. reported
or acted upon) in the history of this routine. Julian was simply
trying to stop us from leaking the ignored errors.

On 12/11/05, Jim Blandy <jimb@red-bean.com> wrote:
> Not being familiar with that code either, this looks bogus to me. If
> there are some error conditions we expect and anticipate, then go
> ahead and test for them explicitly, and "succeed" if we got one of
> them. But to indiscriminately ignore errors???
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 11 19:52:01 2005

This is an archived mail posted to the Subversion Dev mailing list.