[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17725 - trunk/subversion/libsvn_subr

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2005-12-11 14:49:52 CET

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

lundblad@tigris.org wrote:
> Author: lundblad
> Date: Sun Dec 11 07:05:53 2005
> New Revision: 17725
>
> Modified:
> trunk/subversion/libsvn_subr/io.c
>
> Log:
> Protect against certain translation mistakes that could lead to crashes.
>
> Note that this is a special case. For most functions, we add flags to the
> xgettext invocation, but it seems wrong to add knowledge about this internal
> function to our makefiles.
>
> * subversion/libsvn_subr/io.c
> (svn_io_file_flush_to_disk, svn_io_file_close, svn_io_file_getc,
> svn_io_file_info_get, svn_io_file_read, svn_io_file_read_full,
> svn_io_file_seek, svn_io_file_write, svn_io_file_write_full): Mark
> strings expliicitly as begin printf format strings.

Please revert.

This has no effect on the generated potfile, since the appropriate flags
already are present in Makefile.in.

Regarding "it seems wrong to add knowledge about this internal function
to our makefiles" - I disagree, our makefiles are our own, to do with
what we wish, and we don't export their contents to external project.

Also, the 'comment method' has the notable drawback that it is necessary
to mark every individual use of a function (with the potential to miss
one), instead of just listing the function's information just once.

Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)

iD8DBQFDnC6AfFNSmcDyxYARAqphAKCOp8XHIMLUd3gLIW3lPs34JPoh+ACgp0Sc
YMSzWUS4l/7OiZan75ydneM=
=oW+1
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 11 14:50:46 2005

This is an archived mail posted to the Subversion Dev mailing list.