[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: MD5 backward compat code?

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-12-09 12:33:10 CET

Erik Huelsmann wrote:
> In in libsvn_wc/adm_crawler.c:svn_wc_transmit_text_deltas() the MD5
> checksum is checked against a hex representation, but as a fallback
> for pre-Jan 2003 WCs it also compares against a base64 encoded md5.
>
> The checksum-check in libsvn_wc/questions.c:compare_and_verify() -
> which also may need to compare 'old' checksums - doesn't have this
> fallback.

Right. I never investigated the reasons, but I had 'svn' fail a few times a
year or two ago when it encountered old-style checksums for some of the files
in my Subversion source WC which has existed since way before v1.0. The only
operation I remember failing was "revert". I got rid of the old checksums by
updating the individual file to r0 and then updating normally, so there is an
easy work-around.

> I think this is strange, especially since compare_and_verify() is used
> by svn_wc_text_modified_p, which is typically called before a commit
> is started - and thus before svn_wc_transmit_text_deltas() is called.
>
> I'd like to remove the fallback from svn_wc_transmit_text_deltas(),
> also because it is a backward compat to pre-1.0 working copies. I
> think the time to update those to post 1.0-working copies has elapsed
> :-)

+1.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 9 12:34:40 2005

This is an archived mail posted to the Subversion Dev mailing list.