On 12/7/05, Kamesh Jayachandran <kamesh@collab.net> wrote:
> The fix actually runs the configure for neon with CFLAGS and LDFLAGS set to
> /usr/local/include /usr/local/lib respectively for this special case if we
> can see the /usr/local/include/expat.h.
Why should we be hardcoding a special case for /usr/local? It seems
kind of silly to special case one location like that when for all we
know expat could have been installed virtually anywhere. Is there any
reason you went with this approach as opposed to following Max
Bowsher's suggestion in the issue about adding apu-config --cppflags
to CPPFLAGS and thus getting the benefit of finding the exact expat
that APR found?
> + else
> + #Fundamentally there is a difference in the way
> expat(actually expat.h) is identified in the build system between the
> apr-util and neon. apr-util explicitly identifies the expat in /usr,
> /usr/local whereas neon hands off the task to AC_CHECK_HEADER autoconf macro
> which just relies on the default behaviour of $(CC), $(CFLAGS) $(CPPFLAGS)
> which seems to be fine in my gcc version 3.4.3 20041212 (Red Hat
> 3.4.3-9.EL4) to identify expat located in /usr/local. Anyway could reproduce
> the issue with the following command line after renaming all the instances
> of xml-config, xml-config2, expat.h libxml2.so, libxml.so, libexpat.so in
> /usr/include and /usr/lib dir and copying the libexpat.so and expat.h to
> /usr/local/lib and /usr/local/include respectively.
> + #./configure CFLAGS='-nostdinc -I/path/to/build/dir/neon/
> -I/usr/include -I/usr/lib/gcc/<Your vendor info>/<Your gcc-version>/include
> -I/usr/include/linux' CPPFLAGS='-nostdinc -I/usr/include
> -I/usr/include/linux'
> + if test -f /usr/local/include/expat.h; then
> + args="$args CFLAGS='$CFLAGS -I/usr/local/include'
> LDFLAGS='$LDFLAGS -L/usr/local/lib'"
> + fi
> fi
> SVN_SUBDIR_CONFIG(neon, $args)
That's an awfully long comment... If it does need to be there (and
I'm positive that the exact command to reproduce doesn't belong there)
it should at least be broken into multiple lines as the rest of the
file does, not one long line.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 7 20:03:29 2005