Re: [PATCH] Issue 2332, "$Date$" Keywords always expand with their UTF-8 content

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Peter N. Lundblad wrote:
> Oh! I think the correct solution is to recode the whole keyword string
> when replacing it in the file. The problem is that we don't know the
> encoding of the file. Using the user's locale encoding might more often
> be correct than using UTF8.. I used the same philosophy when changing
> conflict makers from UTF8 to the native encoding.
>
> We really need to allow users to store the encoding of a file via some
> property, but that's a bigger issue that I would like to come back to some
> time.

We already have some use of the charset addendum to svn:mime-type:

$ svn pg svn:mime-type COMMITTERS
text/plain; charset=UTF-8

I suggest that the 'what encoding is this local file?' logic be factord
out into a separate function, and that it first check svn:mime-type, and
fall back to the user locale setting otherwise.

Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)

iD8DBQFDltO4fFNSmcDyxYARAr2+AKDgDUo+x164NPTmLDBgYsWWFrBdQACdHhmS
QANA5lrh5JL1LPZ9luuxUv0=
=anfT
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 7 13:22:26 2005