[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Lack of validation in svn_repos_open()

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-12-06 20:29:44 CET

On Tue, Dec 06, 2005 at 12:47:35PM -0500, Greg Hudson wrote:
> On Tue, 2005-12-06 at 17:31 +0000, Malcolm Rowe wrote:
> > This is a bug in the Subversion libraries - we should never abort()
> > if a caller supplies a path with a trailing slash by mistake.
>
> Our philosophy has been that supplying a non-canonical path to a
> function which expects one is like passing an uninitialized or NULL
> value to a function expecting a valid pointer: a programming error which
> should result in a crash or abort, not an error return.
>

Ow. That seems... extreme, not to mention unexpected. Unless I'm
missing something, we don't actually seem to document this anywhere
either: certainly not in svn_repos.h, and not in svn_path.h either.

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 6 20:34:00 2005

This is an archived mail posted to the Subversion Dev mailing list.