Re: [PATCH] OSX Keychain support

Wilfredo Sánchez Vega wrote:
> The only thing I don't understand is whether the patch to
> subversion/libsvn_ra_dav/session.c is actually necessary. I don't
> have a client side cert for any svn repo, so I couldn't test the SSL
> cert password bits.
I traced through the code, and as far as I could see, the credentials
for the client cert password were not being saved.

This is consistent with what I observed when I added the save function
to the provider. I implemented it, expecting it to be called, and was
very surprised when it didn't just work.

It's almost like the original coder did not expect anybody to ever want
to save any client-cert passwords, so they never implemented the code.

-- 
Ken.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org